-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite recipe code and add group support #338
Conversation
Hmm, something seems to have broken mineunit 👀
I tested these in-game and they work as normal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test but code looks sane enough (not sure about the mineunit tests though :/ )
Basically Mineunit isn't approving this: table.insert(minetest.registered_on_mods_loaded, 1, cache_all_recipes) This was one of those things where I wanted to add clear errors and requirement for explicit configuration to allow questionable things. Currently results are still mixed: some stuff has clear Fixtures can be used and in other projects have been used to patch similar things but personally I'd recommend against it. In this case, instead of silently adding required features through fixtures, I'd vote for some public shaming and pointing the finger at Mineunit until fixed. |
Mineunit failed regression tests, click for detailsRegression test log for Technic CNC:
Regression test log for Technic Chests:
Regression test log for Technic:
|
Tested this again, everything seems to be working correctly, so I think this is safe to merge. |
Rewrite of recipe code to fix some issues and add new features. (sorry this took so long)
cooking
recipes) are now cached for performance.Fixes #201, and the issues discussed in #328 and #335.
@nonfreegithub @ThePython10110