[DataGridPro] Fix lazy loading error when existing rows are passed to replaceRows

[martijn-basesoft]

It seems there a sorting issue in combination with the lazy loader. When unstable_replaceRows is called having existing rows in a different order, useGridRows gives an error because it can't find rows because they have been deleted before.

This behavior can be seen in the following demo. This is a fork of the lazy loading example from the documentation with rowLength adjusted to 10. To trigger the error simply change the order of the Name column.
https://codesandbox.io/s/nifty-pike-slzjmd?file=/src/Demo.tsx

This PR includes a suggested fix and test. Let me know if any change is needed and we're happy to update it.

[mui-bot]

Deploy preview: https://deploy-preview-10821--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bfd43ab

[martijn-basesoft]

Any news on this? It seems to me that this is quite a bug.

[romgrk]

I'm not sure I understand the problem and I haven't been able to trigger an error with the linked demo. Can you clarify the problem and the steps to reproduce?

[martijn-basesoft]

You should be able to trigger the error if you open the sandbox demo:

• open https://codesandbox.io/s/nifty-pike-slzjmd?file=/src/Demo.tsx
• click on 'Name' colum header

Then I see the error in the screen:

TypeError
Cannot read properties of undefined (reading 'type')
    at eval (https://slzjmd.csb.app/node_modules/
mui/x-data-grid/hooks/features/rows/useGridRows.js:280:74
    at Object.eval [as unstable_replaceRows] (https://slzjmd.csb.app/node_modules/
mui/x-data-grid/hooks/features/rows/useGridRows.js:280:42
Object.eval
/src/Demo.tsx:88:21
  85 | async (params: GridFetchRowsParams) => {
  86 |   const { slice, total } = await fetchRow(params);
  87 | 
> 88 |   apiRef.current.unstable_replaceRows(params.firstRowToRender, slice);
     |                 ^
  89 |   setRowCount(total);
  90 | },
  91 | [apiRef, fetchRow]

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[romgrk]

I've been able to reproduce the issue. Could you solve the conflicts so we can merge the PR?

[kwek]

@romgrk: I rebased the PR against mui-x/next branch. I didn't get any conflicts however. Is it ok to merge now?