-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix cherry-pick
action
#11446
Conversation
@@ -1,5 +1,5 @@ | |||
on: | |||
pull_request: | |||
pull_request_target: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/marketplace/actions/github-cherry-pick-action#working-with-forked-repositories
And also
mui-x/.github/workflows/maintenance.yml
Line 12 in cec51c5
pull_request_target: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I totally missed this part 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, all of us as well, because we approved your original PR. 🙈 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview: https://deploy-preview-11446--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ... nice effort!
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Signed-off-by: Lukas <llukas.tyla@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing it.
Thank you for the actual heavy-lifting—testing and the working proposal for the branch name! 🙏 🙇 |
Follow up on #11382
Hopefully will fix: https://github.com/mui/mui-x/actions/runs/7197280758/job/19604044778