Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add name attribute to selection checkboxes #15178

Merged
merged 10 commits into from
Dec 30, 2024
Merged

[DataGrid] Add name attribute to selection checkboxes #15178

merged 10 commits into from
Dec 30, 2024

Conversation

derek-0000
Copy link
Contributor

Closes #15112

Add Id to GridCellCheckboxRenderer and GridHeaderCheckbox to avoid issue warning in console.

@mui-bot
Copy link

mui-bot commented Oct 29, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15178--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 56d453e

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Oct 30, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 27, 2024
@cherniavskii cherniavskii added bug 🐛 Something doesn't work needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 13, 2024
@cherniavskii cherniavskii changed the title Add id to GridCellCheckboxRenderer and GridHeaderCheckbox [DataGrid] Add name attribute to selection checkboxes Dec 13, 2024
cherniavskii
cherniavskii approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've updated the PR to use the name attribute because it doesn't have to be unique (as opposed to id).

@cherniavskii cherniavskii enabled auto-merge (squash) December 13, 2024 19:37
@cherniavskii cherniavskii merged commit e5471d4 into mui:master Dec 30, 2024
16 checks passed
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
@derek-0000 @cherniavskii @web-flow
[DataGrid] Add name attribute to selection checkboxes (#15178)
bc739cb 
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] A form field element should have an id or name attribute
4 participants
@derek-0000 @mui-bot @cherniavskii @zannager