-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Update Date calendar styling following MD3 guidelines #9279
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9279--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
I think the increased width goes against point 10 in #7440 and I agree with @oliviertassinari that our picker is already bigger than most competitors @gerdadesign what is your feeling on this density topic ? |
Well, that's the spec that MD3 provides in their design kit. The increased width comes from the fact that they are going for 40px sized day element and margin: 4px to top it all of in order to avoid the potential mis-clicks by having small or no margin between each of the days. 🤔 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I have been navigating around the day dimension problem since mui/material-ui-pickers#1648 (comment). Ideas:
Implementation feedback:
Uploading Screen Recording 2023-06-17 at 20.48.56.mov…
|
It's marked as a breaking change because there is a significant change in minimum container width (it increases from 320px to 360px).
https://deploy-preview-9279--material-ui-x.netlify.app/x/react-date-pickers/