-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
superman: more initial improvements #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! This is much needed.
I've left some comments.
Also, I don't think setPedRotation
and getPedRotation
should be used (CHandleSuperman.lua
) as these functions are deprecated.
Mostly good now 👍🏼 |
I agree, it is really possible to see the development of the system in addition to several observations of error corrections and improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good overall
It's working fine. Also thank you for adding the compatibility layer with element data (opt-in), albeit in a more secure way, so that servers using such checks from other resources can take it easy to migrate to the export/element-data-less way. |
-> With option to restore it by changing SUPERMAN_USE_ELEMENT_DATA to true
-> localPlayer can now only change (force sync to server) it's own data
-> Ensure valid dataKey and dataValue, by checking whether they match types (string & boolean), and allowed key names