Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superman: more initial improvements #577

Merged
merged 17 commits into from
Nov 24, 2024

Conversation

ds1-e
Copy link
Contributor

@ds1-e ds1-e commented Nov 19, 2024

  • Cleanup some unused stuff
  • Fully remove element data (uses custom data system from now on)
    -> With option to restore it by changing SUPERMAN_USE_ELEMENT_DATA to true
  • Introduce some security changes:
    -> localPlayer can now only change (force sync to server) it's own data
    -> Ensure valid dataKey and dataValue, by checking whether they match types (string & boolean), and allowed key names

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! This is much needed.

I've left some comments.

Also, I don't think setPedRotation and getPedRotation should be used (CHandleSuperman.lua) as these functions are deprecated.

[gameplay]/superman/meta.xml Outdated Show resolved Hide resolved
[gameplay]/superman/meta.xml Outdated Show resolved Hide resolved
[gameplay]/superman/CHandleSuperman.lua Show resolved Hide resolved
[gameplay]/superman/CHandleSuperman.lua Show resolved Hide resolved
[gameplay]/superman/CHandleSuperman.lua Show resolved Hide resolved
[gameplay]/superman/CHandleSuperman.lua Show resolved Hide resolved
[gameplay]/superman/data/SData.lua Outdated Show resolved Hide resolved
[gameplay]/superman/data/SData.lua Outdated Show resolved Hide resolved
[gameplay]/superman/data/CData.lua Outdated Show resolved Hide resolved
[gameplay]/superman/config/ShSupermanConfig.lua Outdated Show resolved Hide resolved
@Fernando-A-Rocha
Copy link
Contributor

Mostly good now 👍🏼

@Kinimel
Copy link

Kinimel commented Nov 20, 2024

Mostly good now 👍🏼

I agree, it is really possible to see the development of the system in addition to several observations of error corrections and improvements.

Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall

@Dutchman101
Copy link
Member

It's working fine. Also thank you for adding the compatibility layer with element data (opt-in), albeit in a more secure way, so that servers using such checks from other resources can take it easy to migrate to the export/element-data-less way.

@Dutchman101 Dutchman101 merged commit e1c06c3 into multitheftauto:master Nov 24, 2024
1 check passed
@ds1-e ds1-e deleted the superman-improve branch November 24, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants