Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recently introduced events, name and explosion/projectile checking #588

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ffsPLASMA
Copy link
Contributor

invalid playername check on connect
added onPlayerChangesWorldSpecialProperty
added onPlayerChangesProtectedData
added interval checks for onPlayerProjectileCreation, onExplosion, onVehicleExplode with timer interval and thresholds

ffsPLASMA and others added 7 commits July 29, 2024 16:11
invalid playername check on connect
added onPlayerChangesWorldSpecialProperty
added onPlayerChangesProtectedData
added interval checks for onPlayerProjectileCreation, onExplosion, onVehicleExplode with timer interval and thresholds
Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code overall looks good, but you should add an exception list to special property change, to only flag specific ones

@ffsPLASMA
Copy link
Contributor Author

Code overall looks good, but you should add an exception list to special property change, to only flag specific ones

I rather keep it up to the individual to add exceptions for special properties.

@Nico8340
Copy link
Contributor

I rather keep it up to the individual to add exceptions for special properties.

I understand the intention, but this event works in such a way that it is called every time a special property changes, even when connecting to the server, and it will insert a lot of unnecessary logs.

@ffsPLASMA
Copy link
Contributor Author

I rather keep it up to the individual to add exceptions for special properties.

I understand the intention, but this event works in such a way that it is called every time a special property changes, even when connecting to the server, and it will insert a lot of unnecessary logs.

I mean this could be said about any event added in this resource. I dont see a point to add a property whitelist for whatever world property I deem worthy or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants