-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor headshot #591
base: master
Are you sure you want to change the base?
Refactor headshot #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good job!! But
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job friendo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Please remove all comments, headers (of where it's part of, etc), and documentation/scripting guide lines, and make it clean code only. Thanks for the effort put into these things but im only requesting this because i's not an established practise within other official resources, and to keep things as uniform as possible. Also, in new resources, we now use this for meta.xml: |
Done @Dutchman101 |
Refactors the headshot resource, breaks it into several parts, provides runtime modifiable settings, detailed documentation and examples.