Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor headshot #591

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Nico8340
Copy link
Contributor

@Nico8340 Nico8340 commented Jan 4, 2025

Refactors the headshot resource, breaks it into several parts, provides runtime modifiable settings, detailed documentation and examples.

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good job!! But

[gameplay]/headshot/meta.xml Outdated Show resolved Hide resolved
Copy link

@Lamaaar Lamaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job friendo!

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@Dutchman101
Copy link
Member

Please remove all comments, headers (of where it's part of, etc), and documentation/scripting guide lines, and make it clean code only. Thanks for the effort put into these things but im only requesting this because i's not an established practise within other official resources, and to keep things as uniform as possible.

Also, in new resources, we now use this for meta.xml:
<info author="MTA contributors (github.com/multitheftauto/mtasa-resources)" version="1.0"

@Nico8340
Copy link
Contributor Author

Done @Dutchman101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants