-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revamp juxtaposed function call parsing #33
base: main
Are you sure you want to change the base?
Conversation
not very sure what cases this does and doesn't cover, but it passes the parser's tests (except for the issue above), and detects these calls as such (they and others are incorrectly marked as declarations instead of juxt function calls in test snapshots). |
Really happy that you're working on this! Can't promise that I'll have time to take a look this weekend, but if you get too stuck I might be able to spend some time investigating next week |
…thesized_expression`
…ept `parenthesized_expression`
@murtaza64 this works really well now. please note that this PR contains #32's commits too, and a bunch of miscellaneous fixes to uncommon syntax i personally use in my jenkins libraries. i've validated every node in the new test i added and i'm sure it's parsed correctly. |
this removes ambiguity when matching class names vs all caps variables
hellooo, regarding #5, i got juxtaposed function calls working more robustly by
string hello
is a declaration or function call before run timethe current issue with this refactor thing is that it parses regular function calls with one argument
print("hello")
as a juxt function call with one parenthesized argument instead of a regular function call. i'll have another try with it to make sureparenthesized_expression
is never the argument of a juxt call but wanted to share the news / have you as a second pair of fresh eyes