Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail: Person search: Limit reactivity #373

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Mail: Person search: Limit reactivity #373

merged 6 commits into from
Jan 13, 2025

Conversation

benbucksch
Copy link
Collaborator

  • Avoid that the $: reactivity statements trigger on the value that they change. Put the action in a function.
  • Avoid re-running the search twice for the same person
  • Handle that the user clicked elsewhere before the search completed.

Helps with #368, but not a complete fix

@benbucksch benbucksch self-assigned this Jan 13, 2025
@nix-universe
Copy link
Collaborator

nix-universe commented Jan 13, 2025

With this change, the person list is not rendered in the pane at all. Without the change it is rendered.

@benbucksch
Copy link
Collaborator Author

It works for me. Did you try to restart the app?

Copy link
Collaborator

@nix-universe nix-universe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested: this resolves the 500,000 mail db request issue.

@benbucksch benbucksch merged commit 3e84bba into master Jan 13, 2025
@benbucksch benbucksch deleted the ben/person-search branch January 13, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants