Skip to content

Commit

Permalink
fix(mux-video-react): Don't spread disableCookies to video to avoid w…
Browse files Browse the repository at this point in the history
…arnings (#749)

Same issue as #602. 
<img width="477" alt="Screenshot 2023-08-17 at 17 14 09"
src="https://github.com/muxinc/elements/assets/40537200/04df66ba-a991-4ce2-ab63-ed9e80dc18f9">

Co-authored-by: Petr Doležal <petr.dolezal@ddb.cz>
Co-authored-by: Wesley Luyten <me@wesleyluyten.com>
  • Loading branch information
3 people authored Dec 4, 2023
1 parent 31f6557 commit 06169be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/mux-video-react/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const playerSoftwareVersion = getPlayerVersion();
const playerSoftwareName = 'mux-video-react';

const MuxVideo = React.forwardRef<HTMLVideoElement | undefined, Partial<Props>>((props, ref) => {
const { playbackId, src: outerSrc, children, autoPlay, preload, streamType, _hlsConfig, ...restProps } = props;
const { playbackId, src: outerSrc, children, autoPlay, preload, streamType, disableCookies, _hlsConfig, ...restProps } = props;

const [playerInitTime] = useState(generatePlayerInitTime());
const [src, setSrc] = useState<MuxMediaProps['src']>(toMuxVideoURL(props) ?? outerSrc);
Expand Down

5 comments on commit 06169be

@vercel
Copy link

@vercel vercel bot commented on 06169be Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-svelte-kit – ./examples/svelte-kit

elements-demo-svelte-kit-git-main-mux.vercel.app
elements-demo-svelte-kit-mux.vercel.app
elements-demo-svelte-kit.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 06169be Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-create-react-app – ./examples/create-react-app-with-typescript

elements-demo-create-react-app-git-main-mux.vercel.app
elements-demo-create-react-app-mux.vercel.app
elements-demo-create-react-app.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 06169be Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-vanilla – ./examples/vanilla-ts-esm

elements-demo-vanilla-git-main-mux.vercel.app
elements-demo-vanilla.vercel.app
elements-demo-vanilla-mux.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 06169be Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-vue – ./examples/vue-with-typescript

elements-demo-vue-mux.vercel.app
elements-demo-vue-git-main-mux.vercel.app
elements-demo-vue.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 06169be Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-nextjs – ./examples/nextjs-with-typescript

elements-demo-nextjs.vercel.app
elements-demo-nextjs-mux.vercel.app
elements-demo-nextjs-git-main-mux.vercel.app

Please sign in to comment.