Update engines and packageManager fields in package.json
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
|
@smorimoto is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
smorimoto
commented
Nov 25, 2023
Comment on lines
+4
to
+5
| "node": "^14.0.0 || ^16.0.0 || ^18.0.0 || >20.0.0", | ||
| "npm": "^7.0.0 || ^8.0.0" |
There was a problem hiding this comment.
Make things as intended.
smorimoto
commented
Nov 25, 2023
| @@ -39,5 +39,6 @@ | |||
| "version:update": "lerna version --exact --no-private --conventional-commits --conventional-prerelease=@mux/mux-active-viewer-count", | |||
| "create-release-notes": "lerna run create-release-notes --scope @mux/*", | |||
| "publish-release": "lerna run publish-release --scope @mux/* --" | |||
| } | |||
| }, | |||
| "packageManager": "yarn@1.22.21+sha256.dbed5b7e10c552ba0e1a545c948d5473bc6c5a28ce22a8fd27e493e3e5eb6370" | |||
There was a problem hiding this comment.
We don't have to fix this completely, but at least we need to make it clear that the project depends on yarn v1.
luwes
approved these changes
Dec 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 40 40
Lines 8381 8381
Branches 461 462 +1
=======================================
Hits 6910 6910
Misses 1465 1465
Partials 6 6 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.