Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mux-player): gerwig theme misapplying opt in controls selector. #841

Closed
wants to merge 2 commits into from

Conversation

cjpillsbury
Copy link
Contributor

@cjpillsbury cjpillsbury commented Dec 6, 2023

Also fixes audio only styling issues for gerwig.

@cjpillsbury cjpillsbury requested a review from a team as a code owner December 6, 2023 23:47
Copy link

vercel bot commented Dec 6, 2023

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:48pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:48pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:48pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:48pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:48pm

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #841 (5266d9f) into main (7752977) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   82.44%   82.47%   +0.03%     
==========================================
  Files          40       40              
  Lines        8377     8394      +17     
  Branches      462      461       -1     
==========================================
+ Hits         6906     6923      +17     
  Misses       1465     1465              
  Partials        6        6              
Files Coverage Δ
packages/mux-player/src/themes/gerwig/gerwig.html 100.00% <100.00%> (ø)

@cjpillsbury
Copy link
Contributor Author

Closing. Better fix for theme colors from @luwes in #843

@cjpillsbury cjpillsbury closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant