fix: playback fails when changing videos + reels example #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
commented
Sep 25, 2024
| @@ -0,0 +1,298 @@ | |||
| package com.mux.player.internal.cache | |||
There was a problem hiding this comment.
Renamed from CacheController, not new code
daytime-em
changed the title
daytime-em
changed the title
library/src/androidTest/java/com/mux/player/CacheDatastoreInstrumentationTests.kt
Outdated
Show resolved
Hide resolved
andrewjl-mux
approved these changes
Sep 25, 2024
|
Only change since last green-check was a comment, lets goo |
Merged
daytime-em
added a commit
that referenced
this pull request
Sep 25, 2024
## Improvements * fix: playback fails sometimes when changing videos (#59) Co-authored-by: Emily Dixon <edixon@mux.com> Co-authored-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every
MuxPlayerinstance would share a singleSQLiteOpenHelper. This is a problem because the underlying database could become closed while switching-to and loading new media items. Instead, every Player can have its ownDbHelperinstance, andCacheDatastorewill force the database to stay open until theMuxPlayeris releasedTo test this, I also added a quick & dirty scrolling video carousel.
This also makes
CacheControllerpublic and renames it toMuxPlayerCache. I had to make it public, so I renamed it to avoid confusion in customer apps that might have their own cache classes for REST or something. It's still not part of the public API, and it's not possible to create an instance from the outside or obtain an instance being used