Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add tvOS binary support #31

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

andrewjl-mux
Copy link
Contributor

@andrewjl-mux andrewjl-mux commented Dec 21, 2023

This PR alters IMA packaging in order to support SPM.

Because Google provides separate IMA SDKS for iOS / tvOS and because SPM doesn't yet fully support platform-specific dependency targeting, we need to create a binary artifact in order to support both iOS and tvOS from SPM.

@andrewjl-mux andrewjl-mux requested a review from a team as a code owner December 21, 2023 20:27
@andrewjl-mux andrewjl-mux force-pushed the ajlb/build/tvos-binary-support branch 8 times, most recently from b60dd43 to e470beb Compare December 22, 2023 00:13
tomkordic and others added 3 commits January 3, 2024 11:54
* Ima ads event data populated.

* fix: check playhead time before setting preroll metadata
chore: remove unused folder

fix: update gitignore
@andrewjl-mux andrewjl-mux force-pushed the ajlb/build/tvos-binary-support branch from 0a133b3 to 665b9aa Compare January 3, 2024 19:54
Copy link
Contributor

@daytime-em daytime-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both schemes build for me!

@andrewjl-mux andrewjl-mux force-pushed the ajlb/build/tvos-binary-support branch from 11ab1b1 to 3132818 Compare January 4, 2024 01:29
Base automatically changed from releases/v0.12.0 to master April 17, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants