-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add tvOS binary support #31
Open
andrewjl-mux
wants to merge
15
commits into
master
Choose a base branch
from
ajlb/build/tvos-binary-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
force-pushed
the
ajlb/build/tvos-binary-support
branch
8 times, most recently
from
December 22, 2023 00:13
b60dd43
to
e470beb
Compare
* Ima ads event data populated. * fix: check playhead time before setting preroll metadata
chore: remove unused folder fix: update gitignore
andrewjl-mux
force-pushed
the
ajlb/build/tvos-binary-support
branch
from
January 3, 2024 19:54
0a133b3
to
665b9aa
Compare
daytime-em
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both schemes build for me!
andrewjl-mux
force-pushed
the
ajlb/build/tvos-binary-support
branch
from
January 4, 2024 01:29
11ab1b1
to
3132818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters IMA packaging in order to support SPM.
Because Google provides separate IMA SDKS for iOS / tvOS and because SPM doesn't yet fully support platform-specific dependency targeting, we need to create a binary artifact in order to support both iOS and tvOS from SPM.