fix: remote string source #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 58.77% 58.96% +0.18%
==========================================
Files 30 30
Lines 2358 2371 +13
Branches 130 131 +1
==========================================
+ Hits 1386 1398 +12
- Misses 968 969 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
luwes
force-pushed
the
string-source-example
branch
from
28cd425 to
81260ad
Compare
luwes
force-pushed
the
string-source-example
branch
from
81260ad to
2f12edf
Compare
luwes
force-pushed
the
string-source-example
branch
from
00b3eab to
710c050
Compare
luwes
force-pushed
the
string-source-example
branch
from
710c050 to
ec0b7a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #201
example: https://next-video-demo-git-fork-luwes-string-source-example-mux.vercel.app/string-source
this fixes access to the video config and .json files in am API route.
see https://vercel.com/guides/how-can-i-use-files-in-serverless-functions
this makes remote sources work on Vercel with the caveat that the video json files have to be committed to git!
creating .json files with serverless functions is not the right way to do it.
we will need #143 databases for this