-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cloudflare R2 provider #277
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thank you for this great contribution! I'll have a look soon. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 88.88% 85.52% -3.37%
==========================================
Files 32 35 +3
Lines 2601 2902 +301
Branches 362 362
==========================================
+ Hits 2312 2482 +170
- Misses 286 417 +131
Partials 3 3 ☔ View full report in Codecov by Sentry. |
endpoint: string; | ||
accountId: string; | ||
bucket?: string; | ||
bucketUrlPublic?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way bucketUrlPublic
can be constructed from endpoint, accountId and bucket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a Cloudflare API Token (R2_CF_API_TOKEN) to my knowledge no.
There are two ways for public access:
- r2.dev subdomain
- custom domain
Both must be enabled first on a bucket level.
If a Cloudflare API Token is given to the provider the r2.dev subdomain will be enabled when creating the bucket (if none is given). Making it usable instantly without manual interaction.
sorry for my late comments. Let me know if there is anything else :) |
Talked about this already on Twitter.
I think I could fix the bug I mentioned there.
Let me know if there is something that needs work or is unclear :)