Skip to content

Commit

Permalink
Releases/v1.4.2
Browse files Browse the repository at this point in the history
## Improvements

* Improve data accuracy during post-roll ads in some cases



Co-authored-by: Emily Dixon <edixon@mux.com>
  • Loading branch information
daytime-em authored Oct 18, 2024
1 parent bffea2f commit 34a1b9c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
5 changes: 2 additions & 3 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ muxDistribution {
}
}

// TODO: This is kinda clumsy, packageJavadocs should be a function not a property probably
packageJavadocs = releaseOnTag().call()
packageJavadocs = releaseIfCmdFlag("publicRelease").call()
packageSources = true
publishIf { it.containsIgnoreCase("release") }
artifactoryConfig {
Expand All @@ -77,7 +76,7 @@ muxDistribution {
dependencies {
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1"

api "com.mux:stats.muxcore:8.1.1"
api "com.mux:stats.muxcore:8.1.3"

testImplementation 'junit:junit:4.13.2'
testImplementation 'androidx.test.ext:junit:1.2.1'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,7 @@ abstract class MuxDataSdk<Player, PlayerView : View> @JvmOverloads protected con
} else {
getPackageInfoLegacy(ctx)
}
@Suppress("USELESS_ELVIS") // i dunno man i have a weird feeling about this one
appName = packageInfo.packageName ?: ""
appVersion = packageInfo.versionName ?: ""
} catch (e: PackageManager.NameNotFoundException) {
Expand Down

0 comments on commit 34a1b9c

Please sign in to comment.