-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JupyterLab 4 #40
Conversation
`python -m jupyterlab.upgrade_extension .`
LICENSE.txt --> LICENSE revert `strictNullChecks` setting: true --> false
This reverts commit 4a59905.
@i-aki-y thanks so much for working on this, and apologies for the delay. I'll be able to review this some time this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one suggestion, but everything looks great!
Co-authored-by: Mariko Wakabayashi <mariko@mwkby.com>
@mwakaba2 thank you for your time. I also corrected the package name defined in pyproject.toml that was overwritten by the upgrade script:
I think this should be the same as the name previously defined in setup.py
Sure, I made this pypi account: https://pypi.org/user/i-aki-y/ |
awesome, thanks @i-aki-y ! I invited you as an owner of the package, so you now have the power to publish it. 🔥 |
@mwakaba2 Thanks! I accepted pypi invitation.
OK, I would like to try this release to confirm the release process. |
@mwakaba2 Now, I published the new version 0.5.0! I confirmed that |
@i-aki-y awesome, thank you! 🙌 |
This PR upgrades the extension to support JupyterLab 4 (fix #39 ).
I used the
jupyterlab.upgrade_extension
script according to this migration guide:https://jupyterlab.readthedocs.io/en/stable/extension/extension_dev.html
After the script application, I added some manual fixes (see the commit log for details):
strictNullChecks
in tsconfig.json: true --> falsejupyterlab-notification
(jupyterlab_notification
is created by script)Here is the log of
jupyterlab.upgrade_extension
script:Some comments about the upgrade script:
The following configs look to be included in package.json.
The upgrade script changes build toolchains from the setuptools to the hatchling (https://hatch.pypa.io/latest/).
The build settings are now found in
pyproject.toml
instead ofsetup.*
.The
RELEASE.md
explains the new release flow.This upgrade also adds some
.github/workflows/*
.I did not examine how they work actually, but they use the jobs defined in the following repositories:
https://github.com/jupyterlab/maintainer-tools
https://github.com/jupyter-server/jupyter_releaser
The CHANGELOG.md is almost empty now, but the workflow requires it, so I left it.