fix: remove instabox (#478)

myparcelnl · Apr 5, 2024 · 20b74e6 · 20b74e6
1 parent 563f388
commit 20b74e6
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 155 deletions.
diff --git a/src/Helper/MyParcelCollection.php b/src/Helper/MyParcelCollection.php
@@ -22,7 +22,6 @@
 use MyParcelNL\Sdk\src\Exception\ApiException;
 use MyParcelNL\Sdk\src\Exception\MissingFieldException;
 use MyParcelNL\Sdk\src\Factory\ConsignmentFactory;
-use MyParcelNL\Sdk\src\Model\Carrier\CarrierInstabox;
 use MyParcelNL\Sdk\src\Model\Carrier\CarrierUPS;
 use MyParcelNL\Sdk\src\Model\Consignment\AbstractConsignment;
 use MyParcelNL\Sdk\src\Model\Consignment\BaseConsignment;
@@ -830,7 +829,7 @@ private function getNewCollectionFromResult($result): self
             $consignment = ConsignmentFactory::createByCarrierId($shipment['carrier_id'])->setApiKey($apiKey);
 
             //TODO: MY-32524 Make AbstractConsignmentAdapter for carrier specific exceptions
-            if (CarrierInstabox::ID === $shipment['carrier_id'] || CarrierUPS::ID === $shipment['carrier_id']) {
+            if (CarrierUPS::ID === $shipment['carrier_id']) {
                 $shipment['barcode'] = $shipment['barcode'] ?: $shipment['external_identifier'];
             }
 

diff --git a/src/Model/Carrier/CarrierInstabox.php b/src/Model/Carrier/CarrierInstabox.php
diff --git a/src/Model/Consignment/InstaboxConsignment.php b/src/Model/Consignment/InstaboxConsignment.php
diff --git a/src/Validator/Consignment/InstaboxConsignmentValidator.php b/src/Validator/Consignment/InstaboxConsignmentValidator.php
diff --git a/test/Model/Fulfilment/OrderCollectionTest.php b/test/Model/Fulfilment/OrderCollectionTest.php
@@ -25,7 +25,7 @@ class OrderCollectionTest extends TestCase
         'cc'            => 'NL',
         'city'          => 'Leiden',
         'location_code' => 'ed14eb91-7374-4dcc-a41d-34c0d3e45c01',
-        'location_name' => 'Instabox',
+        'location_name' => 'Dropoff',
         'number'        => '2',
         'number_suffix' => 'H',
         'postal_code'   => '2321 TD',

diff --git a/test/Services/CarrierConfigurationServiceTest.php b/test/Services/CarrierConfigurationServiceTest.php
@@ -5,7 +5,6 @@
 namespace MyParcelNL\Sdk\Test\Services;
 
 use MyParcelNL\Sdk\src\Model\Account\Shop;
-use MyParcelNL\Sdk\src\Model\Carrier\CarrierInstabox;
 use MyParcelNL\Sdk\src\Services\Web\AccountWebService;
 use MyParcelNL\Sdk\src\Services\Web\CarrierConfigurationWebService;
 use MyParcelNL\Sdk\Test\Bootstrap\TestCase;