[WIP] Add tests #185

Stoakes · 2017-11-02T15:42:39Z

This is a work in progress.

Update current tests
Add some new ones
Run all of them on travis
A special attention to doctypes, so as to check Le document type AP n'est pas correctement installé #175 is always wrong

theofidry · 2017-11-04T12:17:15Z

.travis.yml

    - docker-compose up -d
-#    - docker-compose run --rm web composer install -o -n
-    - sleep 10 && docker-compose run --rm web php bin/console cache:clear -e=test --no-warmup
+    - sleep 10 && docker-compose run --rm web php bin/console cache:clear -e=prod --no-warmup


is docker necessary here? You have a VM you can freely configure, docker is a major slowdown

Yes, it is.
We rely on Docker to provide a 5 command line installation. It brought several Junior-Entreprise on board thanks to that feature. Travis checks that the install process is working for every commit.

theofidry · 2017-11-04T12:20:58Z

features/bootstrap/FeatureContext.php

@@ -85,6 +85,12 @@ public function createDatabase()
        ]);
        $output = new BufferedOutput();
        $application->run($input, $output);
+
+        $input = new ArrayInput([


Don't create a database for your tests before each scenario, it's horribly slow. Instead create a clean empty database before running your tests, have a @BeforeScenario hook starting a transaction and rollback that transaction in @AfterScenario. It is way more efficient, the only downside would be if you wanted to take a peek at the database content in the middle of the tests which wouldn't work anymore.

Note that it won't work with SQLite, but I recommend to not use SQLite anyway as it doesn't have real support of any of the RDBSM features of PostgreSQL or MySQL such as transactions, foreign key constraints, cascade persist/delete etc.

theofidry · 2017-11-04T12:23:02Z

features/bootstrap/FeatureContext.php

@@ -85,6 +85,12 @@ public function createDatabase()
        ]);
        $output = new BufferedOutput();
        $application->run($input, $output);
+
+        $input = new ArrayInput([
+            'command' => 'demo:create_data',


I also recommend to avoid to load global data for your tests and instead load specific data you need for your scenarios. It's way easier to manage. If you change the data loaded globally, it can very easily break a lot of tests that were depending on it, if your data is specific for each scenario, it can only break that specific scenario

That's true.

However, we have too few developers to afford such additional work right now.

theofidry · 2017-11-04T12:26:42Z

features/doctypes/default-doctypes.feature

+  # the "@createSchema" annotation provided by Behat creates a temporary SQLite database for testing the API
+  @createSchema
+  Scenario: I can export the default AP
+    Given I am logged in as "admin"


a scenario should be "Given, When and Then". Given a predicate, when I do an action, then I get this reaction.

Given I am logged as admin And I have an etude "Etude 2" When I access the etude "Etude 2" Then I should see the etude "Etude 2"

Some comments:

When creating objects, you can give them a label like "Etude 2" above, so in a context you can have an array label => object to easily access to them.

It seems bad phrasing (and it is), the label is used again and again at each sentence. While it could be phrased better, this approach have a big advantage: it makes it stateless. If you don't want to repeat yourself, you would need to keep track of the subject which is a PITA and very error prone. So trading off on the phrasing a bit is a good idea here

And I have an etude "Etude 2": so you create your object and you store it with the label Etude 2

When I access the etude "Etude 2": for an UI tests, it can be "visit the page X". For a non-UI tests, it can be get the object from the repository

Then I should see the etude "Etude 2" for your UI tests, you can indeed test the response type (HTML, JSON...) and the status code

theofidry · 2017-11-04T12:38:23Z

features/personne/filiere_crud.feature

  # The "@dropSchema" annotation must be added on the last scenario of the feature file to drop the temporary SQLite database
  @dropSchema
  Scenario: I can delete a Filiere
    Given I am logged in as "admin"
-    Given I am on "/personne/filiere/modifier/1"
+    Given I am on "/personne/filiere/modifier/6"


You're using MySQL which is a bit of a shame, but if you ever switch to PostgreSQL (which is better in every imaginable ways), the auto-generation of ids is made by sequences. For example for user, if you have auto-generated int IDs for it, it would be provided by a sequence user_id. All the sequence does is creating a new value and incrementing itself. While this seem a bit more complicated, it allows you to easily reset it between each scenarios, which means you have a better control on the IDs used

Ok.

By the way, MySQL is suited for the Jeyser CRM project.

Moreover we will not switch because:

It would break every already running installation (or create a cumbersome migration for little to no additionnal business value)

It makes imports easier because Siaje also uses MySQL.

Tooling is better (pgadminTools << PhpMyAdmin)

It would break all the previous migrations

If you're using InnoDB it should be possible to reset the auto-increment with:

ALTER TABLE tablename AUTO_INCREMENT = 1

which would be an alternative solution.

Switching of DB is never easy so I don't recommend to invest too much time on it. It might however be worth checking if the migrations have any MySQL specific features or not. It's far easier to switch from MySQL to PostgreSQL than vice-versa as MySQL is much more limited than Postgres.

Regarding the tooling I don't have much of an opinion as I'm really fine using the CLI client, it's something you need do at some point anyway but I understand phpmyadmin can be enough for limited usage.

Demo data are now quite complete, and are valid. Thus they are relevant for functionnal and behavioural testing Also, change @afterstep handler to display page url, page title and beginning of content if the step fails.

Everything is green :)

etude.typeprestation

Stoakes force-pushed the add-tests branch 7 times, most recently from e01571d to 3e0fbc0 Compare November 2, 2017 19:29

theofidry reviewed Nov 4, 2017

View reviewed changes

Stoakes added 6 commits February 18, 2018 09:30

Use demo data for tests

58c04f8

Demo data are now quite complete, and are valid. Thus they are relevant for functionnal and behavioural testing Also, change @afterstep handler to display page url, page title and beginning of content if the step fails.

Update Poste tests

e027787

Fix typo in FiliereController

0a45b04

Update Filiere tests

77919b6

Update user tests

fe9dea1

Run Behat tests on Travis

b77c119

Stoakes force-pushed the add-tests branch 10 times, most recently from cff1c23 to cee0b99 Compare February 18, 2018 11:51

Fix doctype export tests

5a31efa

Everything is green :)

Stoakes force-pushed the add-tests branch from cee0b99 to 5a31efa Compare February 18, 2018 12:03

Stoakes added 2 commits February 18, 2018 13:06

Remove previously deleted field on etude

819d748

etude.typeprestation

2.5.0 ready

d2ec243

Stoakes force-pushed the add-tests branch from e704ab1 to d2ec243 Compare February 18, 2018 17:40

Stoakes merged commit 7f71439 into master Feb 18, 2018

Stoakes deleted the add-tests branch February 21, 2018 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add tests #185

[WIP] Add tests #185

Stoakes commented Nov 2, 2017

theofidry Nov 4, 2017

Stoakes Nov 5, 2017

theofidry Nov 4, 2017

theofidry Nov 4, 2017

Stoakes Nov 5, 2017

theofidry Nov 4, 2017

theofidry Nov 4, 2017

theofidry Nov 4, 2017

Stoakes Nov 5, 2017 •

edited

Loading

theofidry Nov 5, 2017 •

edited

Loading

[WIP] Add tests #185

[WIP] Add tests #185

Conversation

Stoakes commented Nov 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Stoakes Nov 5, 2017 • edited Loading

Choose a reason for hiding this comment

theofidry Nov 5, 2017 • edited Loading

Choose a reason for hiding this comment

Stoakes Nov 5, 2017 •

edited

Loading

theofidry Nov 5, 2017 •

edited

Loading