feat(Send Email Node): New operation sendAndWait #12775
Open
+264
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…send-email-sendandwait-operation
michael-radency
added
node/improvement
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
dana-gill
requested changes
Jan 22, 2025
…send-email-sendandwait-operation
…send-email-sendandwait-operation
test added, could you take another look? |
dana-gill
previously approved these changes
Jan 23, 2025
|
|
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-2294-send-email-sendandwait-operation
|
| Run status |
|
| Run duration | 04m 38s |
| Commit |
|
| Committer | Michael Kret |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
415
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
4-node-creator.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Node Creator > should not show actions for single action nodes |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 30 specs in Cypress Cloud.
e2e/7-workflow-actions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Workflow Actions > should not save workflow if canvas is loading |
Test Replay
Screenshots
Video
|
|
…send-email-sendandwait-operation
…tion node, added configureWaitTillDate to sendEmail and outlook nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New operation sendAndWait
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2294/send-email-sendandwait-operation