Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Alllow using S3 compatible object stores over http #12812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 23, 2025

Summary

The current object store implementation for binary data assumes that

  1. the service is available over http
  2. the service supports regions
  3. the service needs authentication

If someone chooses to run a local minio instance in a private network, they can run it over http, and without any auth.

To support such cases, this PR

  1. adds an option to allow switching the procotol from https to http
  2. makes region and auth optional

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...inary-data/object-store/object-store.service.ee.ts 82.75% 4 Missing and 1 partial ⚠️
packages/cli/src/commands/base-command.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware that changing the structure of the config schema is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants