Fix paragraph regex #408
Merged
Fix paragraph regex #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spassarop - is this ready for @BloodDrag0n to test? I'd like to get confirmation from him he's happy with these changes before we push out a release. |
|
Yes. In fact I added as test what he used as input.
…On Wed, 20 Dec 2023 at 12:42 Dave Wichers ***@***.***> wrote:
@spassarop <https://github.com/spassarop> - is this ready for @BloodDrag0n
<https://github.com/BloodDrag0n> to test? I'd like to get confirmation
from him he's happy with these changes before we push out a release.
—
Reply to this email directly, view it on GitHub
<#408 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHL3BMLKUX3LDVBZWLB4HJLYKMBO7AVCNFSM6AAAAABA4CXHC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUG4YDONJZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
OK. That's good. @BloodDrag0n - can you test this and confirm you are good with it before we merge it into main? |
|
Sure @davewichers we will test this on our side and let you know. |
|
@davewichers, We have tested on our side, there is no issue with the regex. Thank You! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed on issue #402, regex for
paragraphin attributes format could be improved preserving allowed characters.