Skip to content

Commit

Permalink
Update task names in CI workflow and add format check task
Browse files Browse the repository at this point in the history
Updated task names in CI workflow file for a clearer understanding of the tests being run during the workflow and added format check task in pyproject.toml file. These tests now exactly follow the workflow: Check format, Check lint, Check mypy, then run unittests with coverage report. This change makes the intent of each stage of the Continuous Integration process more explicit and ensures that a format check is included in the workflow execution.
  • Loading branch information
nakashima-hikaru committed Nov 26, 2023
1 parent 1bf4ce7 commit 8522e57
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,15 @@ jobs:
poetry-version: "1.6.1"
- name: Install dependencies
run: poetry install
- name: Mypy
run: poetry run task mypy
- name: Ruff
- name: Check format
run: |
poetry run task check_format
- name: Check lint
run: |
poetry run task lint
- name: pytest coverage
- name: Check mypy
run: poetry run task mypy
- name: Run unittests with coverage check
run: |
poetry run pytest --cov --junitxml=pytest.xml --cov-report=term-missing:skip-covered | tee pytest-coverage.txt
- name: Create Coverage Comment
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ build-backend = "poetry.core.masonry.api"

[tool.taskipy.tasks]
format = "python -m ruff format ."
check_format = "python -m ruff format . --check"
test = "python -m pytest -v --cov --cov-branch --no-cov-on-fail --cov-report=html"
# lint
lint_src = "python -m ruff check reinforcement_learning"
Expand Down

1 comment on commit 8522e57

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL9140100%

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 0.831s ⏱️

Please sign in to comment.