Support discard uploaded file or loaded text function #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samerd please review |
samerd
requested changes
Oct 28, 2019
| @@ -160,9 +160,9 @@ def close(self): | |||
| self._delete_file(self.backup_file) | |||
| self._netmiko_close() | |||
|
|
|||
| def _send_command(self, command): | |||
| def _send_command(self, command, expect_string=None): | |||
There was a problem hiding this comment.
this was done in another commit
we'll have conflicts here.
There was a problem hiding this comment.
yes that what I told u about its shared code that all of them will use
I use it here
self._send_command(command, expect_string=expected_config_mode)
if u want I can replace it with
self.device.send_command(command, expect_string=expect_string) #original one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support discard uploaded file or loaded text function
discard_config: delete config from the remote or just flush the candidate temp. text.