Feature/get environment #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samerd
requested changes
Jun 7, 2019
napalm_onyx/onyx_ssh.py
Outdated
| show_temperature = json.loads(self.device.send_command('show temperature | json-print')) | ||
| show_resources = json.loads(self.device.send_command('show resources | json-print')) | ||
|
|
||
| if 'MGMT' in show_fan.keys(): |
There was a problem hiding this comment.
using key() is not efficient.
you can use:
if 'MGMT' in show_fan:
or:
for fan in show_fan.get('MGMT', dict()):
this comment for all resource types below
| @wrap_test_cases | ||
| def test_get_environment(self, test_case): | ||
| """Test get_facts method.""" | ||
| modale_environment = { |
There was a problem hiding this comment.
typo: should be: model_environment
| "temperature": dict, | ||
| } | ||
| _environment = self.device.get_environment() | ||
| assert helpers.test_model(modale_environment, _environment) |
There was a problem hiding this comment.
shouldn't you iterate over all dict items?
atta
force-pushed
the
feature/get_environment
branch
from
b62d7f3 to
6b1d6d7
Compare
- so you can make use of it in https://github.com/digitalocean/netbox
|
@atta , |
|
since the driver isn't working anymore since many months it would be nice if you could review the acceptance policy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added get_environment to napalm-onyx so you can make use of it in https://github.com/digitalocean/netbox