Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export shouldShowRequestPermissionRationale for Android 13 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sublime392
Copy link

This simply exports the function so that it can be used directly in client apps.
Nothing was changed with the manner in which shouldShowRequestPermissionRationale is currently being used in the plugin. However, that usage does not seem to really match with the Android docs. It seems that when shouldShowRequestPermissionRationale returns true, the permission check returns GRANT_RESULTS.DENIED. This does not make it possible to distinguish between a truly denied permission and one that simply needs to show a rationale before requesting the permission.

As per Android docs*, the flow should be:

  1. check for permission
  2. check for shouldShowRequestPermissionRationale
  3. request permission (after showing rationale if indicated by step 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant