Skip to content

Commit

Permalink
Add check for removed Push Consumer options
Browse files Browse the repository at this point in the history
  • Loading branch information
samuelattwood committed Jan 13, 2025
1 parent 3b23887 commit 24c422a
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/controller/consumer_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ func (r *ConsumerReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
return ctrl.Result{}, nil
}

if consumer.Spec.FlowControl || consumer.Spec.DeliverSubject != "" || consumer.Spec.DeliverGroup != "" || consumer.Spec.HeartbeatInterval != "" {
log.Info("FlowControl, DeliverSubject, DeliverGroup, and HeartbeatInterval are Push Consumer options, which are no longer supported. Skipping consumer creation or update.")
return ctrl.Result{}, nil
}

// Create or update stream
if err := r.createOrUpdate(ctx, log, consumer); err != nil {
return ctrl.Result{}, fmt.Errorf("create or update: %s", err)
Expand Down

0 comments on commit 24c422a

Please sign in to comment.