Fix off by 1 error in fetching postsynaptic names

* closes #109 * thanks to @mmc46 * also make sure to pass on connection object to catmaid_get_neuronnames
natverse · Apr 15, 2019 · 807d8e8 · 807d8e8
1 parent 46c7461
commit 807d8e8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/R/catmaid_skeleton.R b/R/catmaid_skeleton.R
@@ -499,9 +499,9 @@ catmaid_get_connectors_between <- function(pre_skids=NULL, post_skids=NULL,
   # deal with neuron names
   if(get_names){
     # make this a single call for efficiency
-    allnames <- catmaid_get_neuronnames(c(ddf$pre_skid, ddf$post_skid))
+    allnames <- catmaid_get_neuronnames(c(ddf$pre_skid, ddf$post_skid), conn = conn, pid=pid, ...)
     ddf$pre_name <- allnames[seq_along(ddf$pre_skid)]
-    ddf$post_name <- allnames[seq_along(ddf$post_skid)+length(ddf$pre_skid)-1]
+    ddf$post_name <- allnames[seq_along(ddf$post_skid)+length(ddf$pre_skid)]
   }
 
   # move some columns to front