Skip to content

Commit

Permalink
Update DataTable test when data row is pressed for Material 3 (flut…
Browse files Browse the repository at this point in the history
…ter#137230)

This updates one of them M3 test to use golden test from flutter#135901
Keeping it consistent with this [update](flutter#136809 (comment))
  • Loading branch information
TahaTesser authored Oct 27, 2023
1 parent 008a10f commit 64f31b2
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions packages/flutter/test/material/data_table_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// This file is run as part of a reduced test set in CI on Mac and Windows
// machines.
@Tags(<String>['reduced-test-set'])
@TestOn('!chrome')
library;

Expand Down Expand Up @@ -1725,16 +1728,11 @@ void main() {
));

final TestGesture gesture = await tester.startGesture(tester.getCenter(find.text('Content1')));
await tester.pump(const Duration(milliseconds: 200)); // splash is well underway
final RenderBox box = Material.of(tester.element(find.byType(InkWell)))as RenderBox;
await tester.pump(); // start the splash animation
await tester.pump(const Duration(milliseconds: 100)); // splash is underway
// Material 3 uses the InkSparkle which uses a shader, so we can't capture
// the effect with paint methods.
expect(
box,
paints
..rect()
..rect(rect: const Rect.fromLTRB(0.0, 56.0, 800.0, 104.0), color: pressedColor.withOpacity(0.0)),
);
// the effect with paint methods. Use a golden test instead.
await expectLater(find.byType(InkWell), matchesGoldenFile('data_table_test.data_row_pressed.png'));
await gesture.up();
});

Expand Down Expand Up @@ -2033,7 +2031,7 @@ void main() {
);

// Go without crashes.

expect(tester.takeException(), isNull);
});

testWidgetsWithLeakTracking('DataTable clip behavior', (WidgetTester tester) async {
Expand Down

0 comments on commit 64f31b2

Please sign in to comment.