[TEST] 639 CFund Tests #640

proletesseract · 2019-11-23T07:04:51Z

Related to Issue #639

Adding the foundations for a comprehensive test suite for the NavCoin DAO / CFund.

I've removed the "Work in Progress" label on this PR. Instead of waiting for every test to be written i think its better to merge what is currently there and then slowly add tests otherwise we could be waiting forever until every possible scenario is covered.

It's important to understand that what is in this PR is just some simple building blocks, once the basics are covered we can use these building blocks to construct ever increasingly complex test scenarios and perhaps eventually even automate/randomise test scenarios to see if anything breaks after sequences of events which we might not think to test.

I've merged in the latest master and all the tests i've written so far are passing. Can I please get some reviews and comments or approvals.

The current test scenarios that are covered can be found in the test plan but are summarised below;

Scenarios

Scenario 001

ID	CFUND_003
Reporter	@proletesseract
Author	@proletesseract
Satus	Done
Description	It should create a proposal and let it expire
File	`./001-proposal-expired.py`

Given I have created a proposal
When The proposal is not voted on
Then the proposal should expire

Test Steps

Activate CFund
Donate to the CFund
Create a proposal
Do not cast any votes
End the full round of voting cycles
Check proposal expired

Scenario 002

ID	CFUND_002
Reporter	@proletesseract
Author	@proletesseract
Satus	Done
Description	It should create a proposal and the network should reject the proposal
File	`./002-proposal-rejected.py`

Given I have created a proposal
When The proposal receives the consensus of no votes
Then the proposal should be rejected

Test Steps

Activate CFund
Donate to the CFund
Create a proposal
Votes no on the proposal
End the full round of voting cycles
Check proposal is rejected

Scenario 003

ID	CFUND_003
Reporter	@proletesseract
Author	@proletesseract
Satus	Done
Description	It should create a proposal and the network should accept the proposal
File	`./003-proposal-accepted.py`

Given I have created a proposal
When The proposal receives the consensus of yes votes
Then the proposal should be accepted

Test Steps

Activate CFund
Donate to the CFund
Create a proposal
Votes yes on the proposal
End the full round of voting cycles
Check proposal is rejected

Scenario 004

ID	CFUND_004
Reporter	@proletesseract
Author	@proletesseract
Satus	Done
Description	It should fail to create a payment request for an expired proposal
File	`./004-proposal-expired-preq.py`

Given I have an expired proposal
When A payment request is made
Then the payment request should not exist

Test Steps

Activate CFund
Donate to the CFund
Create a proposal
Do not cast any votes
End the full round of voting cycles
Submit a payment request
Check payment request does not exist

Scenario 005

ID	CFUND_005
Reporter	@proletesseract
Author	@proletesseract
Satus	Done
Description	It should fail to create a payment request for a rejected proposal
File	`./005-proposal-expired-preq.py`

Given I have a rejected proposal
When A payment request is made
Then the payment request should not exist

Test Steps

Activate CFund
Donate to the CFund
Create a proposal
Votes no on the proposal
End the full round of voting cycles
Submit a payment request
Check payment request does not exist

Scenario 006

ID	CFUND_006
Reporter	@proletesseract
Author	@proletesseract
Satus	Done
Description	It should create a payment request for an accepted proposal
File	`./006-proposal-accepted-preq.py`

Given I have an accepted proposal
When A payment request is made
Then the payment request should exist

Test Steps

Activate CFund
Donate to the CFund
Create a proposal
Votes yes on the proposal
End the full round of voting cycles
Submit a payment request
Check payment request exists

navbuilder · 2019-11-23T08:23:27Z

A new build of 1cb6165 has completed succesfully!
Binaries available at https://build.nav.community/binaries/639-cfund-tests

navbuilder · 2019-11-23T09:48:45Z

A new build of 8af9dfa has completed succesfully!
Binaries available at https://build.nav.community/binaries/639-cfund-tests

navbuilder · 2019-11-24T02:42:16Z

A new build of fb5d08d has completed succesfully!
Binaries available at https://build.nav.community/binaries/639-cfund-tests

navbuilder · 2020-01-26T00:38:56Z

A new build of 87a744a has completed succesfully!
Binaries available at https://build.nav.community/binaries/639-cfund-tests

proletesseract · 2020-01-26T01:51:16Z

IDK why the cfunddb-statehash.py is failing to sync the nodes back together in travis. Works fine for me locally (but im using OSX) and i haven't changed that test. Ill keep re-running it.

chasingkirkjufell · 2020-02-25T15:06:12Z

Ran all the tests and they all passed.

mxaddict · 2020-02-25T15:07:30Z

What's the tl;dr on this PR?

…

On Tue, Feb 25, 2020, 23:06 chasingkirkjufell ***@***.***> wrote: Ran all the tests and they all passed. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#640?email_source=notifications&email_token=AAIDAKONWFK4YVABMSJNCTLREUXWLA5CNFSM4JQY5LYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM4JYNA#issuecomment-590912564>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDAKIO636BS43NGFFY3WTREUXWLANCNFSM4JQY5LYA> .

chasingkirkjufell · 2020-02-25T15:09:25Z

What's the tl;dr on this PR?
…
On Tue, Feb 25, 2020, 23:06 chasingkirkjufell @.***> wrote: Ran all the tests and they all passed. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#640?email_source=notifications&email_token=AAIDAKONWFK4YVABMSJNCTLREUXWLA5CNFSM4JQY5LYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM4JYNA#issuecomment-590912564>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDAKIO636BS43NGFFY3WTREUXWLANCNFSM4JQY5LYA .

Functional testing of the cfund and potentially DAO. Things like creating a proposal and vote no and assert that the proposal is rejected.

mxaddict · 2020-06-12T02:20:54Z

IDK why the cfunddb-statehash.py is failing to sync the nodes back together in travis. Works fine for me locally (but im using OSX) and i haven't changed that test. Ill keep re-running it.

I've fixed this issue here: #715

mxaddict · 2020-06-12T02:21:23Z

@proletesseract if you have a few minutes, can you check out the conflict for qa/rpc-tests/dao/test-plan.md ?

I think this PR is ready to merge

Conflicts: qa/rpc-tests/dao/test-plan.md

navbuilder · 2020-06-12T04:11:07Z

A new build of 37d6ca1 has completed succesfully!
Binaries available at https://build.nav.community/binaries/639-cfund-tests

navbuilder · 2020-06-12T06:47:56Z

A new build of ededb0a has completed succesfully!
Binaries available at https://build.nav.community/binaries/639-cfund-tests

proletesseract added 2 commits November 23, 2019 17:42

basic framework up

c43d9b5

first two tests added

1cb6165

proletesseract added the work in progress label Nov 23, 2019

tidy up whitespace

8af9dfa

proletesseract changed the title ~~639 cfund tests~~ [WIP] 639 CFund Tests Nov 23, 2019

proletesseract added 2 commits November 24, 2019 13:38

more tests added

eb9b77c

updated readme

fb5d08d

Merge branch 'master' into 639-cfund-tests

87a744a

proletesseract added ready for review and removed work in progress labels Jan 25, 2020

proletesseract changed the title ~~[WIP] 639 CFund Tests~~ 639 CFund Tests Jan 25, 2020

proletesseract requested review from aguycalled, chasingkirkjufell and mxaddict January 25, 2020 23:30

Fixed qa/rpc-tests/cfunddb-statehash.py

205c4f4

mxaddict changed the title ~~639 CFund Tests~~ [TEST] 639 CFund Tests Jun 12, 2020

mxaddict added 3 commits June 12, 2020 10:42

Merge remote-tracking branch 'fork/master' into 639-cfund-tests

9ccdb61

Conflicts: qa/rpc-tests/dao/test-plan.md

Fixed failing test

37d6ca1

Merge branch 'fixed-cfunddb-statehash.py' into 639-cfund-tests

ededb0a

mxaddict approved these changes Jun 12, 2020

View reviewed changes

aguycalled approved these changes Jun 12, 2020

View reviewed changes

aguycalled merged commit 673a656 into navcoin:master Jun 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEST] 639 CFund Tests #640

[TEST] 639 CFund Tests #640

proletesseract commented Nov 23, 2019 •

edited

Loading

navbuilder commented Nov 23, 2019

navbuilder commented Nov 23, 2019

navbuilder commented Nov 24, 2019

navbuilder commented Jan 26, 2020

proletesseract commented Jan 26, 2020 •

edited

Loading

chasingkirkjufell commented Feb 25, 2020

mxaddict commented Feb 25, 2020 via email

chasingkirkjufell commented Feb 25, 2020 •

edited

Loading

mxaddict commented Jun 12, 2020

mxaddict commented Jun 12, 2020

navbuilder commented Jun 12, 2020

navbuilder commented Jun 12, 2020

[TEST] 639 CFund Tests #640

[TEST] 639 CFund Tests #640

Conversation

proletesseract commented Nov 23, 2019 • edited Loading

Scenarios

Scenario 001

Test Steps

Scenario 002

Test Steps

Scenario 003

Test Steps

Scenario 004

Test Steps

Scenario 005

Test Steps

Scenario 006

Test Steps

navbuilder commented Nov 23, 2019

navbuilder commented Nov 23, 2019

navbuilder commented Nov 24, 2019

navbuilder commented Jan 26, 2020

proletesseract commented Jan 26, 2020 • edited Loading

chasingkirkjufell commented Feb 25, 2020

mxaddict commented Feb 25, 2020 via email

chasingkirkjufell commented Feb 25, 2020 • edited Loading

mxaddict commented Jun 12, 2020

mxaddict commented Jun 12, 2020

navbuilder commented Jun 12, 2020

navbuilder commented Jun 12, 2020

proletesseract commented Nov 23, 2019 •

edited

Loading

proletesseract commented Jan 26, 2020 •

edited

Loading

chasingkirkjufell commented Feb 25, 2020 •

edited

Loading