You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Hi, only a personal preference here. I prefer to depend on projects (libInternationalization) instead of jas (gvsig-i18n.jar). It's a bit easier to forgive to push the jar and if someone makes changes in libInternationalization and not push the jar (other developer maybe doesn't have libInternationalization in her workspace) the jar will be not up to date. Depending in the project makes that the workspace have to has all the real dependencies.
And, when you depend on projects it's easier to make changes on gvSIG to make the "git status" not throw a lot of "not really modified jars". We can talk about this offline.
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right, it's a common project we all have in our workspaces, so there is no reason for not including it as a dependency.
I think GitHub will delete all the pull request comments if I delete the branch and push it again with cleaned commits, so I'm going to commit the change in a new one and I'll clean all them before merging the branch onto master.
55cc416There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, only a personal preference here. I prefer to depend on projects (libInternationalization) instead of jas (gvsig-i18n.jar). It's a bit easier to forgive to push the jar and if someone makes changes in libInternationalization and not push the jar (other developer maybe doesn't have libInternationalization in her workspace) the jar will be not up to date. Depending in the project makes that the workspace have to has all the real dependencies.
And, when you depend on projects it's easier to make changes on gvSIG to make the "git status" not throw a lot of "not really modified jars". We can talk about this offline.
55cc416There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right, it's a common project we all have in our workspaces, so there is no reason for not including it as a dependency.
I think GitHub will delete all the pull request comments if I delete the branch and push it again with cleaned commits, so I'm going to commit the change in a new one and I'll clean all them before merging the branch onto master.