Added EC6 module handling and fixed up Blueprints #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loads simple MJS. import needs work
Loads module code unwrapped (you cant wrap import statements they must be at the top.) Current limitation, no argument parametres loads initial code file, fails to load import properly
Will load and run a file with extensions ".mjs" now as an EC6 module
Added a run module node to blueprints
UJavascriptIsolate updated for UE5 to use UCLASS(BlueprintType) so it is constructable within a blueprint Added trivial blueprint example to Content because there are none currently
slight changes in 5.3 to TargetArchitecture. Usedto be a string. Is now an object you have to do ToString() on.
Small but significant fixes in the v8 plugin codebase for UE 5.3 build environmenht
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will load and execute scripts with the extension .mjs as EC6 modules
I hope its reasonably clean. I kept all my code to a new file except for the hook to invoke it.
This does make it a bit redundant but had the smallest impact on the original codebase.
I also made UJavaIsolate a UCLASS(BlueprintType) to expose it for creation in blueprints in UE5 and added a trivial Blueprint example