Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag System #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Flag System #9

wants to merge 1 commit into from

Conversation

auscompgeek
Copy link
Contributor

In the original plan we described a system that would remove highly flagged questions, although we never got around to doing it, it is a critical element to making this "internet safe".

This could be ran as a scheduled task (read: using cron) or just something that was calculated after each flagged request.

@auscompgeek
Copy link
Contributor

We now expose a method of flagging questions now, at least.

@paked
Copy link
Member Author

paked commented Jan 18, 2015

can't remember if I moved this feature to master or not....

@auscompgeek
Copy link
Contributor

You did. 😜

@paked
Copy link
Member Author

paked commented Apr 30, 2015

closable?

@auscompgeek
Copy link
Contributor

… hang on a second. I was wrong. There's a link to /flag/{{ question_results.question_id }} in the post game lobby, but there's no handler registered to handle those.

@auscompgeek
Copy link
Contributor

… and that'd be because it's in a branch. How did I not notice that?

@paked
Copy link
Member Author

paked commented Jul 5, 2015

rip merging...

@paked
Copy link
Member Author

paked commented Jul 5, 2015

OH FRUITCAKES!

@paked
Copy link
Member Author

paked commented Jul 5, 2015

You have no idea what just happened in my brain

@paked
Copy link
Member Author

paked commented Jul 5, 2015

I was like "A flags! Davo means command line flags! Of course! I did that, they're in master, but the branch isn't up to date... I guess I can fix that", after a few minutes of subconcious thinking I was like "cow! It was the reporting system that needed merging, I DIDNT GET ANY MERGE CONFLICTS THOUGH SO I HOPE IT WORKS!".... #ineedsleep

@auscompgeek
Copy link
Contributor

god @paked stop pulling all nighters

@auscompgeek
Copy link
Contributor

I DIDNT GET ANY MERGE CONFLICTS THOUGH SO I HOPE IT WORKS!

Uhh.

4f47fb2
Conflicts:
trivia.py

Whatever you say, @paked.

@auscompgeek
Copy link
Contributor

Rebased and force-pushed to branch flag as commit 5383245.

@auscompgeek
Copy link
Contributor

Whilst we're here, can we get some tests landed for this as well?

@auscompgeek
Copy link
Contributor

Do we also want to improve the flagging system to track who flagged the question as well? It'll require a database schema change, but it'd be worth it, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants