Fixed Bug Not Loading/Saving in adventure.dsk #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the bug in saving and loading Implementation is in https://github.com/prasys/ADVENT-Flex
prasys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a bug in the original implementation of adventure whereby the original author made the assumption that all of the variables are stored consecutively but however this is not the case for FLEX. Therefore, in our implementation - we had to change the save and load functions so that it writes individual values into disk and then loads them back in.
Also Flex likes everything to be in Upper case. So I've fixed them as well
Two files were modified ADVENT.C and SAVEADV.C
The full source code can be seen here (with the modifications)
https://github.com/prasys/ADVENT-Flex
I am submitting this because I thought it would be helpful for people who want to play colossal cave adventure
Let me know should you require more details