Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: updates near-* dependencies to 0.28 release #423

Merged
merged 3 commits into from
Dec 13, 2024
Merged

chore!: updates near-* dependencies to 0.28 release #423

merged 3 commits into from
Dec 13, 2024

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn commented Dec 13, 2024 •
edited
Loading

Also:

  • Bumped up the thiserror crate to version 2.
  • Changed callback to work with TransactionV0 instead of the Transaction. As Transaction doesn't support the actions_mut function.
  • rust-tolchain 1.80 pin to stable

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Dec 13, 2024 •
edited
Loading

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@FroVolod 8

Your contribution is much appreciated with a final score of 8!
You have received 88 (80 base + 10% lifetime bonus) Sloth points for this contribution

@FroVolod received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo self-requested a review December 13, 2024 12:40
@FroVolod FroVolod self-requested a review December 13, 2024 13:03
FroVolod
FroVolod approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@FroVolod FroVolod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 8

@FroVolod FroVolod merged commit c19e525 into main Dec 13, 2024
11 checks passed
@FroVolod FroVolod deleted the nearcore-2.4.0 branch December 13, 2024 13:17
@frol frol mentioned this pull request Dec 13, 2024
Merged
akorchyn pushed a commit that referenced this pull request Dec 17, 2024
@frol
chore: release v0.17.0 (#424)
3fc78b6 
## 🤖 New release
* `near-cli-rs`: 0.16.1 -> 0.17.0 (⚠️ API breaking changes)

### ⚠️ `near-cli-rs` breaking changes

```
--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field inner of struct SignedDelegateActionAsBase64, previously in file /tmp/.tmpAefZh2/near-cli-rs/src/types/signed_delegate_action.rs:5

--- failure struct_pub_field_now_doc_hidden: pub struct field is now #[doc(hidden)] ---

Description:
A pub field of a pub struct is now marked #[doc(hidden)] and is no longer part of the public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/struct_pub_field_now_doc_hidden.ron

Failed in:
  field SignedDelegateActionAsBase64.inner in file /tmp/.tmpyy9aLz/near-cli-rs/src/types/signed_delegate_action.rs:4
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.17.0](v0.16.1...v0.17.0)
- 2024-12-16

### Added

- Added the ability to send a signed meta-transaction from a file (#428)
- Added the ability to send a signed transaction from a file (#412)
- Added the ability to use TEACH ME mode to create an account with a
faucet service sponsor (#407)

### Fixed

- Fixed field name for JSON file with transaction information
(signed-transaction-info.json) (#427)

### Other

- add CODEOWNERS (#426)
- print searched location on miss on sign-with-legacy-keychain (#422)
- [**breaking**] updates near-* dependencies to 0.28 release (#423)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroVolod FroVolod FroVolod approved these changes

@dj8yfo dj8yfo Awaiting requested review from dj8yfo dj8yfo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akorchyn @race-of-sloths @FroVolod