Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts/generate-data.sh #94

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

AcKing-Sam
Copy link
Contributor

Currently the address for github repo of ldbc_snb_datagen for hadoop has changed. The generate-data.sh now redirects the address to ldbc_snb_datagen for spark instead of hadoop. Therefore, I cannot download the correct package to generate data.

The latest repo address should be: https://github.com/ldbc/ldbc_snb_datagen_hadoop. And the v0.3.3 package can use wget to download, which is wget https://github.com/ldbc/ldbc_snb_datagen_hadoop/archive/refs/tags/v0.3.3.tar.gz.
In the script, I use ${LDBC_SNB_DATAGEN_VERSION} to represent the version number.

…n has changed, need revise git clone xxx command
…n has changed, need revise git clone xxx command
@wey-gu wey-gu requested a review from HarrisChu December 19, 2023 07:43
wey-gu
wey-gu previously approved these changes Dec 19, 2023
@wey-gu
Copy link
Member

wey-gu commented Dec 19, 2023

Thanks for adapting this upstream change, besides, decoupling git with wget seems to be reasonable to me, too.

What do you think, please @HarrisChu

@AcKing-Sam
Copy link
Contributor Author

I am sorry for missing to change the variable in scripts/env.sh LDBC_SNB_DATAGEN_VERSION. I removed the v in it, and added the v in scripts/generate-data.sh. In this way, the tests should be passed.

@AcKing-Sam AcKing-Sam requested a review from wey-gu December 19, 2023 08:27
@AcKing-Sam
Copy link
Contributor Author

Yes, I intended to only modify scripts/generate-data.sh, while I found that the variable LDBC_SNB_DATAGEN_VERSION in scripts/env.sh was only used here. So I modify both scripts/env.sh and scripts/generate-data.sh and added v in front of the variable.

@AcKing-Sam
Copy link
Contributor Author

@HarrisChu Hello, in this issue, I try to update the scripts/generate-data.sh.

To be specific, update the github repo address of ldbc_snb_datagen_hadoop because the original address did not work, which redirected to ldbc_snb_datagen_spark.

@HarrisChu
Copy link
Collaborator

It's ok for me

@HarrisChu HarrisChu merged commit 9772705 into nebula-contrib:master Dec 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants