Skip to content

Commit

Permalink
Remove buggy use of setStrokeDashArray and bump version to 1.7.4.
Browse files Browse the repository at this point in the history
  • Loading branch information
neekfenwick committed Nov 3, 2022
1 parent 43887e0 commit 70f471b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 8 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dagmike/bin-packing",
"version": "1.7.3",
"version": "1.7.4",
"description": "2D bin packing PHP implementation",
"type": "library",
"license": "MIT",
Expand Down
20 changes: 20 additions & 0 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions src/Helpers/VisualisationHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,6 @@ public static function generateVisualisation(RectangleBinPack $bin, $opts = [])
);
}

$draw->setStrokeColor($strokeColour);

$draw->setFillOpacity(0);
$draw->setStrokeDashArray([null]);
$draw->setStrokeWidth(1);
// $draw->rectangle($margin, $margin, $bin->getBinWidth() + $margin, $bin->getBinHeight() + $margin);

$imagick->setImageFormat("png");
$imagick->drawImage($draw);

Expand Down

0 comments on commit 70f471b

Please sign in to comment.