feat: course-authoring MFE s3 deployment action (#1) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
reviewed
Dec 17, 2024
| env: | ||
| PUBLIC_PATH: ${{ vars.PUBLIC_PATH_CDN }} | ||
| APP_ID: ${{ vars.APP_ID }} | ||
| MFE_CONFIG_API_URL: ${{ vars.MFE_CONFIG_API_URL }} |
There was a problem hiding this comment.
This is going to point to stage or prod domains. But what could we do with alpha?
There was a problem hiding this comment.
probably you are referring to this https://edunext.atlassian.net/browse/FUTUREX-1023 and yes, this will use stage as the other mfes
johanseto
approved these changes
Dec 17, 2024
andrey-canon
force-pushed
the
redwood-mig/add_deploy_mfe_s3_action
branch
from
ca40aa5 to
dbd8426
Compare
andrey-canon
changed the base branch from
open-release/redwood.nelp
to
open-rc/redwood.nelp
andrey-canon
added a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Johan Seto Kaiba <51926076+johanseto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration pr #1 issue