Certificate status #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarIthawi
force-pushed
the
certificate-status
branch
2 times, most recently
from
6853953 to
2ab09ce
Compare
|
@OmarIthawi If you want this to be deployed in the stage learning mfe deployment, you have to configure the PR with base branch: |
OmarIthawi
changed the base branch from
ednx-release/mango.nelp
to
ednx-rc/mango.nelp
* fix: [MICROBA-1769] Cert status before course end Right now, learners who are nonpassing are able to view information about thier certificates early at the course end screen and progress pages. This is because we show messaging around the nonpassing state in some cases before a course ends and certificates are available. This can also lead to cases where grades are not finalized and students who may be passing see a scary nonpassing message instead. This change makes it so during the course exit, a student who finishes a course before the course is over will see the celebration screen regardless of passing status. Once the course is over (or if certificates are available immediately), and they are still not passing, they will see the nonpassing messaging. The same change was made for the certificate status alert in the progress tab.
OmarIthawi
force-pushed
the
certificate-status
branch
from
2ab09ce to
6f52e2c
Compare
|
Thanks @johanseto done, thanks for the heads up! |
|
Closing in favor of #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick the following commits to fix certificate issue in the progress tab: