Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And/add like dislike component #18

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Jan 24, 2024

Description

This adds the frontend-essentials dependency and includes the like-dislike component in the Sequence file

How to test

  1. Add to your platform settings MFE_CONFIG["COURSE_EXPERIENCE_API_URL"] = "http://local.overhang.io:8000/eox-nelp/api/experience/v1"
  2. Go to a unit
  3. press like or dislike
  4. Reload and verify previous state, alternative you can check the admin panel /admin/eox_nelp/likedislikeunit

Result

like-dislike-test.mp4

@andrey-canon andrey-canon marked this pull request as ready for review January 24, 2024 22:05
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Is working in my local env.
Only some jest config but ok.
Peek 2024-01-25 17-40

@@ -29,6 +29,7 @@
"url": "https://github.com/openedx/frontend-app-learning/issues"
},
"dependencies": {
"@edunext/frontend-essentials": "^2.0.0-rc",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gonna be changed from rc in future?

@andrey-canon andrey-canon merged commit 7f6ca9b into open-release/palm.nelp Jan 31, 2024
3 checks passed
andrey-canon added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants