Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frontend-essentials translations #37

Conversation

andrey-canon
Copy link
Collaborator

Description

Migration pr of #20 issue

How to test

Follow the instructions of the original pr

Result

image

@andrey-canon andrey-canon force-pushed the redwood-mig/add_essentials_translations branch from 6fe57c6 to 5efae8f Compare November 25, 2024 22:05
@andrey-canon andrey-canon force-pushed the redwood-mig/add_report_button branch from 3cc8d18 to 04aac9d Compare November 28, 2024 19:24
@andrey-canon andrey-canon force-pushed the redwood-mig/add_essentials_translations branch from 5efae8f to c9c5ed2 Compare November 28, 2024 19:25
@andrey-canon andrey-canon force-pushed the redwood-mig/add_report_button branch from 04aac9d to d4336fd Compare November 28, 2024 19:57
@andrey-canon andrey-canon force-pushed the redwood-mig/add_essentials_translations branch from c9c5ed2 to cc2eca1 Compare November 28, 2024 19:58
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For essentials components. The translations were working. IN the rest of mfe is seems strange, anyway essentials are ok.

Screencast.from.29-11-24.15.34.56.webm

Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For essentials components. The translations were working. IN the rest of mfe is seems strange, anyway essentials are ok.

Screencast.from.29-11-24.15.34.56.webm

@andrey-canon andrey-canon force-pushed the redwood-mig/add_report_button branch from d4336fd to 5c03c96 Compare November 29, 2024 22:10
@andrey-canon andrey-canon changed the base branch from redwood-mig/add_report_button to open-release/redwood.nelp November 29, 2024 22:13
@andrey-canon andrey-canon force-pushed the redwood-mig/add_essentials_translations branch from cc2eca1 to e0df0e1 Compare November 29, 2024 22:17
@andrey-canon andrey-canon merged commit 0fb0357 into open-release/redwood.nelp Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants