Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rpc error #894

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix rpc error #894

merged 2 commits into from
Mar 25, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Mar 25, 2024

This pr fix the rpc error

@Jim8y
Copy link
Contributor Author

Jim8y commented Mar 25, 2024

@cschuchardt88

AnnaShaleva
AnnaShaleva previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sure that we've fixed all of them in #815.

AnnaShaleva
AnnaShaleva reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format check is failing.

@Jim8y Jim8y requested a review from AnnaShaleva March 25, 2024 14:31
@Jim8y
Copy link
Contributor Author

Jim8y commented Mar 25, 2024 •
edited
Loading

I was sure that we've fixed all of them in #815.

This was newly introduced in a merged pr, but i have no idea why it can pass the workflow.

@AnnaShaleva please review again

@vncoelho
Copy link
Member

testing here again

@cschuchardt88
Copy link
Member

testing here again

Its sample simple change; shouldn't affect anything but RpcServer Method error output

@vncoelho vncoelho merged commit 50d6995 into neo-project:master Mar 25, 2024
4 checks passed
@vncoelho
Copy link
Member

Application log is fixed.

Oracle still not

#42 24.21 /opt/neo-modules/src/OracleService/OracleService.cs(260,65): error CS1503: Argument 3: cannot convert from 'byte[]' to 'Neo.Cryptography.ECC.ECCurve' [/opt/neo-modules/src/OracleService/OracleService.csproj]

@cschuchardt88
Copy link
Member

cschuchardt88 commented Mar 25, 2024 •
edited
Loading

Application log is fixed.

Oracle still not

#42 24.21 /opt/neo-modules/src/OracleService/OracleService.cs(260,65): error CS1503: Argument 3: cannot convert from 'byte[]' to 'Neo.Cryptography.ECC.ECCurve' [/opt/neo-modules/src/OracleService/OracleService.csproj]

net8.0 upgrade PR will fix it...

@Jim8y Jim8y deleted the fix-rpcerror branch March 25, 2024 15:12
shargon
shargon reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change

@cschuchardt88
Copy link
Member

cschuchardt88 commented Mar 25, 2024 •
edited
Loading

@shargon currently main.yml doesn't do a dotnet build on all projects on this repo... Which is way is was missed.

@shargon
Copy link
Member

shargon commented Mar 25, 2024

@shargon currently main.yml doesn't do a dotnet build on all projects on this repo... Which is way is was missed.

I don't know, time ago neo-modules was not maintained by core devs...

@Jim8y Jim8y restored the fix-rpcerror branch May 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon left review comments

@vncoelho vncoelho vncoelho approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@AnnaShaleva AnnaShaleva Awaiting requested review from AnnaShaleva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jim8y @vncoelho @cschuchardt88 @shargon @AnnaShaleva