Add hardfork HF_Echidna #3454

Jim8y · 2024-08-07T16:27:49Z

Description

AnnaShaleva · 2024-08-07T17:41:09Z

src/Neo.CLI/config.fs.mainnet.json

@@ -40,7 +40,8 @@
      "HF_Aspidochelone": 3000000,
      "HF_Basilisk": 4500000,
      "HF_Cockatrice": 5800000,
-      "HF_Domovoi": 5800000
+      "HF_Domovoi": 5800000,
+      "HF_Echidna": 0


It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna enum?

It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna enum?

Its placeholder, can be updated before merge to the master.

This will make configs stored in the master branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna (we need it and will use it), but update configs later.

This will make configs stored in the master branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna (we need it and will use it), but update configs later.

this will not be merged to the master branch until we decides to release new version.

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

# Conflicts: # src/Neo/Neo.csproj # src/Neo/SmartContract/Native/RoleManagement.cs

* Allow callstates to use HF * Rename to method * Other rename * Change the way * Reduce changes * Reduce changes * Adapt name always * Avoid string when only is lower the first char * UT * Test all * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Reuse Load from stream * Unify * Fix default logic * Change ContractMethod to allowMultiple * Use LowerInvariant * Move CheckingHardfork * Remove optional arg * Fix build * Avoid file not found error --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <shargon@gmail.com>

Solves two problems: * inability to estimate GAS needed for registerCandidate in a regular way because of its very high fee (more than what normal RPC servers allow) * inability to have MaxBlockSystemFee lower than the registration price which is very high on its own (more than practically possible to execute) Fixes #3552. Signed-off-by: Roman Khimov <roman@nspcc.ru>

#3643) #3597 introduces `onNEP17Payment` handler to native NeoToke contract starting from Echidna hardfork. We need to update the list of supported standards respectively. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Fix UT * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* fix unnecessary change * Clean using --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>

Jim8y · 2025-01-11T12:54:08Z

as discussed in the meeting, please review this pr and merge into master branch.

All changes in this pr are actually reviewed previously, just make sure.

cschuchardt88 · 2025-01-11T18:39:18Z

src/Neo/ProtocolSettings.cs

+            if (!Path.IsPathRooted(path))
+            {
+                // Combine with the executable directory if relative
+                var executablePath = AppDomain.CurrentDomain.BaseDirectory;


This can be set to whatever. Better to use AppContext.BaseDirectory

This is a collection branch, no direct change should be made here, please update in a pr.

nan01ab · 2025-01-14T12:33:32Z

src/Neo/SmartContract/Native/RoleManagement.cs

@@ -51,6 +60,7 @@ public ECPoint[] GetDesignatedByRole(DataCache snapshot, Role role, uint index)
        }

        [ContractMethod(CpuFee = 1 << 15, RequiredCallFlags = CallFlags.States | CallFlags.AllowNotify)]
+        [Obsolete]


Add some additional information about Obsolete?

BTW, this method is not obsolete and shouldn't be marked as obsolete. I'd say we need to revert this change.

AnnaShaleva · 2025-01-16T20:55:02Z

src/Neo.CLI/config.mainnet.json

@@ -38,7 +38,8 @@
      "HF_Aspidochelone": 1730000,
      "HF_Basilisk": 4120000,
      "HF_Cockatrice": 5450000,
-      "HF_Domovoi": 5570000
+      "HF_Domovoi": 5570000,
+      "HF_Echidna": 5570001


We shouldn't enable it in this PR. Remove these values; we'll set the proper ones in a separate PR before the release.

AnnaShaleva · 2025-01-16T21:02:51Z

src/Neo/SmartContract/Native/LedgerContract.cs

-        [ContractMethod(CpuFee = 1 << 15, RequiredCallFlags = CallFlags.ReadStates, Name = "getTransaction")]
+        [ContractMethod(CpuFee = 1 << 15, RequiredCallFlags = CallFlags.ReadStates, Name = nameof(GetTransaction))]
        private Transaction GetTransactionForContract(ApplicationEngine engine, UInt256 hash)


I won't do this. GetTransaction is a separate Ledger method that is not related to GetTransactionForContract; it's just about the fact that these methods have the same name.

Nothing changed here, the first letter is lowecase during abi construction

AnnaShaleva · 2025-01-16T21:04:55Z

src/Neo/SmartContract/Native/RoleManagement.cs

@@ -51,6 +60,7 @@ public ECPoint[] GetDesignatedByRole(DataCache snapshot, Role role, uint index)
        }

        [ContractMethod(CpuFee = 1 << 15, RequiredCallFlags = CallFlags.States | CallFlags.AllowNotify)]
+        [Obsolete]


BTW, this method is not obsolete and shouldn't be marked as obsolete. I'd say we need to revert this change.

add hardofork HF_Echidna

bcc5fd0

Jim8y added the Blocked This issue can't be worked at the moment label Aug 7, 2024

Jim8y marked this pull request as draft August 7, 2024 16:44

AnnaShaleva reviewed Aug 7, 2024

View reviewed changes

Add entries to Designation event (#3397)

e63f10b

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

Jim8y added this to the v3.8.0 milestone Aug 8, 2024

[Neo Core StdLib] Add Base64url (#3453)

9d16c53

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

This was referenced Aug 12, 2024

core: introduce Echidna hardfork nspcc-dev/neo-go#3554

Merged

*: move Notary contract out of P2PSigExtensions under Echidna hardfork nspcc-dev/neo-go#3478

Draft

Jim8y and others added 9 commits October 2, 2024 20:55

add hardofork HF_Echidna

f746f8d

Add entries to Designation event (#3397)

8d7f9e8

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

[Neo Core StdLib] Add Base64url (#3453)

3fc8077

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

add hardofork HF_Echidna

7e31d0c

Add entries to Designation event (#3397)

993e3fe

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

[Neo Core StdLib] Add Base64url (#3453)

37bf0cb

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

format

7dba130

Merge branch 'HF_Echidna' of github.com:neo-project/neo into HF_Echidna

0457ccd

# Conflicts: # src/Neo/Neo.csproj # src/Neo/SmartContract/Native/RoleManagement.cs

cschuchardt88 force-pushed the HF_Echidna branch from 16a9c29 to 0457ccd Compare November 17, 2024 12:41

cschuchardt88 and others added 6 commits November 17, 2024 07:44

Merge Master

d7a291e

Fixed typo

6e780c0

Added back #3397

02d6ab9

Fixed tests

8fb30df

fixed global.json

f9244eb

Merge branch 'master' into HF_Echidna

650c9e9

Jim8y changed the title ~~Add hardofork HF_Echidna~~ Add hardfork HF_Echidna Nov 20, 2024

Jim8y and others added 4 commits November 20, 2024 18:08

Merge branch 'master' into HF_Echidna

331541a

Merge branch 'master' into HF_Echidna

eb96d14

Merge branch 'master' into HF_Echidna

74498e5

Merge branch 'master' into HF_Echidna

577c431

shargon and others added 11 commits December 19, 2024 15:37

Merge branch 'master' into HF_Echidna

498ed91

Merge branch 'master' into HF_Echidna

08c3be6

fix tests error (#3636)

59fe8b5

* fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <shargon@gmail.com>

specify the argument exception information.

e2acc64

Fix Ut (#3635)

216c39e

Merge branch 'master' into HF_Echidna

8470de5

[Core Add] Add support to Ed25519 (#3507)

b1a3ea3

* fix unnecessary change * Clean using --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>

Jim8y added Waiting for Review and removed Blocked This issue can't be worked at the moment labels Jan 11, 2025

Jim8y requested review from AnnaShaleva, roman-khimov, cschuchardt88, nan01ab and shargon January 11, 2025 12:53

Merge branch 'master' into HF_Echidna

f4f1980

cschuchardt88 reviewed Jan 11, 2025

View reviewed changes

Jim8y marked this pull request as ready for review January 14, 2025 06:21

Merge branch 'master' into HF_Echidna

7fb5f7a

shargon approved these changes Jan 14, 2025

View reviewed changes

vncoelho approved these changes Jan 14, 2025

View reviewed changes

Merge branch 'master' into HF_Echidna

ec78580

nan01ab reviewed Jan 14, 2025

View reviewed changes

AnnaShaleva mentioned this pull request Jan 16, 2025

Implement NotaryAssisted transaction attribute #3175

Open

12 tasks

AnnaShaleva reviewed Jan 16, 2025

View reviewed changes

Merge branch 'master' into HF_Echidna

32410be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hardfork HF_Echidna #3454

Add hardfork HF_Echidna #3454

Jim8y commented Aug 7, 2024 •

edited

Loading

AnnaShaleva Aug 7, 2024

Jim8y Aug 8, 2024

roman-khimov Aug 8, 2024

Jim8y Aug 8, 2024

Jim8y commented Jan 11, 2025

cschuchardt88 Jan 11, 2025 •

edited

Loading

Jim8y Jan 14, 2025

nan01ab Jan 14, 2025 •

edited

Loading

AnnaShaleva Jan 16, 2025

AnnaShaleva Jan 16, 2025 •

edited

Loading

AnnaShaleva Jan 16, 2025

shargon Jan 16, 2025

AnnaShaleva Jan 16, 2025

Add hardfork HF_Echidna #3454

Are you sure you want to change the base?

Add hardfork HF_Echidna #3454

Conversation

Jim8y commented Aug 7, 2024 • edited Loading

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jim8y commented Jan 11, 2025

cschuchardt88 Jan 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nan01ab Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnnaShaleva Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jim8y commented Aug 7, 2024 •

edited

Loading

cschuchardt88 Jan 11, 2025 •

edited

Loading

nan01ab Jan 14, 2025 •

edited

Loading

AnnaShaleva Jan 16, 2025 •

edited

Loading