Adapts procedure registry to depend on the cypher version

packages/language-server/src/lintWorker.ts

@@ -1,6 +1,22 @@
-import { lintCypherQuery } from '@neo4j-cypher/language-support';
+import {
+  DbSchema,
+  lintCypherQuery as _lintCypherQuery,
+  _internalFeatureFlags,
+} from '@neo4j-cypher/language-support';
 import workerpool from 'workerpool';
 
+function lintCypherQuery(
+  query: string,
+  dbSchema: DbSchema,
+  featureFlags: { cypher25?: boolean } = {},
+) {
+  // We allow to override the consoleCommands feature flag
+  if (featureFlags.cypher25 !== undefined) {
+    _internalFeatureFlags.cypher25 = featureFlags.cypher25;
+  }
+  return _lintCypherQuery(query, dbSchema);
+}
+
 workerpool.worker({ lintCypherQuery });
 
 type LinterArgs = Parameters<typeof lintCypherQuery>;

packages/language-server/src/linting.ts

@@ -1,3 +1,4 @@
+import { _internalFeatureFlags } from '@neo4j-cypher/language-support';
 import { Neo4jSchemaPoller } from '@neo4j-cypher/schema-poller';
 import debounce from 'lodash.debounce';
 import { join } from 'path';
@@ -31,7 +32,11 @@ async function rawLintDocument(
     }
 
     const proxyWorker = (await pool.proxy()) as unknown as LintWorker;
-    lastSemanticJob = proxyWorker.lintCypherQuery(query, dbSchema);
+    lastSemanticJob = proxyWorker.lintCypherQuery(
+      query,
+      dbSchema,
+      _internalFeatureFlags,
+    );
     const result = await lastSemanticJob;
 
     sendDiagnostics(result);

packages/language-server/src/server.ts

@@ -12,14 +12,21 @@ import {
 
 import { TextDocument } from 'vscode-languageserver-textdocument';
 
-import { syntaxColouringLegend } from '@neo4j-cypher/language-support';
+import {
+  syntaxColouringLegend,
+  _internalFeatureFlags,
+} from '@neo4j-cypher/language-support';
 import { Neo4jSchemaPoller } from '@neo4j-cypher/schema-poller';
 import { doAutoCompletion } from './autocompletion';
 import { cleanupWorkers, lintDocument } from './linting';
 import { doSignatureHelp } from './signatureHelp';
 import { applySyntaxColouringForDocument } from './syntaxColouring';
 import { Neo4jSettings } from './types';
 
+if (process.env.CYPHER_25 === 'true') {
+  _internalFeatureFlags.cypher25 = true;
+}
+
 const connection = createConnection(ProposedFeatures.all);
 
 // Create a simple text document manager.

packages/language-support/src/featureFlags.ts

@@ -1,5 +1,6 @@
 interface FeatureFlags {
   consoleCommands: boolean;
+  cypher25: boolean;
 }
 
 export const _internalFeatureFlags: FeatureFlags = {
@@ -11,4 +12,5 @@ export const _internalFeatureFlags: FeatureFlags = {
   it's own cache and preference on if console commands are enabled or not.
   */
   consoleCommands: false,
+  cypher25: false,
 };

packages/schema-poller/src/metadataPoller.ts

@@ -4,6 +4,7 @@ import {
   DbSchema,
   Neo4jFunction,
   Neo4jProcedure,
+  _internalFeatureFlags,
 } from '@neo4j-cypher/language-support';
 import { EventEmitter } from 'events';
 import { Neo4jConnection } from './neo4jConnection.js';
@@ -100,6 +101,7 @@ export class MetadataPoller {
     private readonly events: EventEmitter,
   ) {
     const isNewerNeo4j =
+      _internalFeatureFlags.cypher25 ||
       databases.find((db) => db.defaultLanguage !== undefined) !== undefined;
 
     this.databases = new QueryPoller({

packages/vscode-extension/src/extension.ts

@@ -30,6 +30,7 @@ export async function activate(context: ExtensionContext) {
     debug: {
       module: debugServer,
       transport: TransportKind.ipc,
+      options: { env: { CYPHER_25: 'true' } },
     },
   };
   // Options to control the language client

packages/vscode-extension/tests/specs/api/syntaxValidation.spec.ts

@@ -294,4 +294,39 @@ suite('Syntax validation spec', () => {
       password,
     );
   });
+
+  test('Errors and warnings are version Cypher version dependant', async () => {
+    // We open a file that is not saved on disk
+    // and change the language manually to Cypher
+    await newUntitledFileWithContent(`
+      CYPHER 5 CALL apoc.create.uuids(5);
+      CYPHER 25 CALL apoc.create.uuids(5)
+  `);
+    const editor = vscode.window.activeTextEditor;
+    await vscode.languages.setTextDocumentLanguage(editor.document, 'cypher');
+
+    // We need to wait here because diagnostics are eventually
+    // consistent i.e. they don't show up immediately
+    await testSyntaxValidation({
+      textFile: undefined,
+      expected: [
+        new vscode.Diagnostic(
+          new vscode.Range(
+            new vscode.Position(1, 20),
+            new vscode.Position(1, 37),
+          ),
+          "Procedure apoc.create.uuids is deprecated. Alternative: Neo4j's randomUUID() function can be used as a replacement, for example: `UNWIND range(0,$count) AS row RETURN row, randomUUID() AS uuid`",
+          vscode.DiagnosticSeverity.Warning,
+        ),
+        new vscode.Diagnostic(
+          new vscode.Range(
+            new vscode.Position(2, 21),
+            new vscode.Position(2, 38),
+          ),
+          "Procedure apoc.create.uuids is not present in the database. Make sure you didn't misspell it or that it is available when you run this statement in your application",
+          vscode.DiagnosticSeverity.Error,
+        ),
+      ],
+    });
+  });
 });