Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: autodetect target arch for builds #1197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikhail-sakhnov
Copy link
Contributor

Use KERNEL_TARGET_ARCH and TARGET_ARCH based on the uname -r instead of always relying on manually passed values. This should enable using current instruction for local development without any changes.

@mikhail-sakhnov mikhail-sakhnov marked this pull request as ready for review January 7, 2025 14:57
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, IIUC this will change the behavior from:

Build for x86 by default

to

Build for the host architecture by default

right?

Otherwise LGTM, modulo one question

Makefile Outdated Show resolved Hide resolved
Use TARGET_ARCH based on the uname -r instead of always relying on manually passed values. This should enable using current instruction for local development without any changes.
Simplify kernel related makefile targets.

Signed-off-by: Misha Sakhnov <misha@neon.tech>
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/autodetect-target-arch branch from f0337a4 to 0ae2807 Compare January 9, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants