Newest projects page #566
Merged
Newest projects page #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rosejbon
reviewed
Nov 24, 2022
| export const Title = ({ children }) => ( | ||
| <div className="hi"> | ||
| {children} | ||
| <style jsx>{``}</style> |
There was a problem hiding this comment.
did you need this styling? :)
rosejbon
reviewed
Nov 24, 2022
| margin-top: 1.5em; | ||
| margin: 0; | ||
| padding: 0; | ||
| border: none; | ||
| } | ||
|
|
||
| .content li + li { |
There was a problem hiding this comment.
If you don't need the margin between the list elements anymore you could remove this bit of css ;)
rosejbon
reviewed
Nov 24, 2022
| @@ -43,28 +62,41 @@ export default ({ problem, solution }) => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <Text size="normal" weight={700}> | |||
| <Text size="normal" color="#561dee" weight={700}> | |||
There was a problem hiding this comment.
Is there a colour variable you could use here?
There was a problem hiding this comment.
I think because this prop was defined as a string I can't use a variable. I think after the site is live I will go back and replace all colours with variables @rosejbon
rosejbon
reviewed
Nov 24, 2022
| maxCharacter="45ch" | ||
| > | ||
| {' '} | ||
| {/* <b>Funded by:</b> {fund} */} |
There was a problem hiding this comment.
Is this the copy you mentioned you were waiting for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project page resembles designs: #516
This page is still awaiting some copy expected by next Monday.