Merge pull request #4894 from mhsdesign/task/followup-4330-remove-plu…

…gin-views

TASK: Followup 4330 remove plugin views

Neos.Neos/Classes/Controller/Backend/ContentController.php

@@ -371,45 +371,6 @@ protected function getAssetProperties(AssetInterface $asset)
         return $assetProperties;
     }
 
-    /**
-     * Fetch the configured views for the given master plugin
-     *
-     * @param string $identifier Specifies the node to look up
-     * @param string $workspaceName Name of the workspace to use for querying the node
-     * @param array<string,string> $dimensions Optional list of dimensions and their values which should be used
-     *                          for querying the specified node
-     * @return string
-     * @throws \Neos\Eel\Exception
-     * @throws \Neos\Flow\Mvc\Routing\Exception\MissingActionNameException
-     * @deprecated remove with UI editors
-     */
-    public function pluginViewsAction($identifier = null, $workspaceName = 'live', array $dimensions = [])
-    {
-        $this->response->setContentType('application/json');
-
-        $views = [];
-        return json_encode((object)$views, JSON_THROW_ON_ERROR);
-    }
-
-    /**
-     * Fetch all master plugins that are available in the current
-     * workspace.
-     *
-     * @param string $workspaceName Name of the workspace to use for querying the node
-     * @param array<string,string> $dimensions Optional list of dimensions and their values
-     *                          which should be used for querying the specified node
-     * @return string JSON encoded array of node path => label
-     * @throws \Neos\Eel\Exception
-     * @deprecated remove with UI editors
-     */
-    public function masterPluginsAction(string $workspaceName = 'live', array $dimensions = [])
-    {
-        $this->response->setContentType('application/json');
-        $masterPlugins = [];
-
-        return json_encode((object)$masterPlugins, JSON_THROW_ON_ERROR);
-    }
-
     /**
      * Signals that a new asset has been uploaded through the Neos Backend
      *

Neos.Neos/Configuration/Policy.yaml

@@ -54,7 +54,7 @@ privilegeTargets:
 
     'Neos.Neos:Backend.EditContent':
       label: General access to content editing
-      matcher: 'method(Neos\Neos\Service\Controller\NodeController->(show|getPrimaryChildNode|getChildNodesForTree|filterChildNodesForTree|getChildNodes|getChildNodesFromParent|create|createAndRender|createNodeForTheTree|move|moveBefore|moveAfter|moveInto|moveAndRender|copy|copyBefore|copyAfter|copyInto|copyAndRender|update|updateAndRender|delete|searchPage|error)Action()) || method(Neos\Neos\Controller\Backend\ContentController->(uploadAsset|assetsWithMetadata|imageWithMetadata|pluginViews|createImageVariant|masterPlugins|error)Action()) || method(Neos\Neos\Controller\Service\AssetProxiesController->(index|show|import|error)Action()) || method(Neos\Neos\Controller\Service\AssetsController->(index|show|error)Action()) || method(Neos\Neos\Controller\Service\NodesController->(index|show|create|error)Action())'
+      matcher: 'method(Neos\Neos\Service\Controller\NodeController->(show|getPrimaryChildNode|getChildNodesForTree|filterChildNodesForTree|getChildNodes|getChildNodesFromParent|create|createAndRender|createNodeForTheTree|move|moveBefore|moveAfter|moveInto|moveAndRender|copy|copyBefore|copyAfter|copyInto|copyAndRender|update|updateAndRender|delete|searchPage|error)Action()) || method(Neos\Neos\Controller\Backend\ContentController->(uploadAsset|assetsWithMetadata|imageWithMetadata|createImageVariant|error)Action()) || method(Neos\Neos\Controller\Service\AssetProxiesController->(index|show|import|error)Action()) || method(Neos\Neos\Controller\Service\AssetsController->(index|show|error)Action()) || method(Neos\Neos\Controller\Service\NodesController->(index|show|create|error)Action())'
 
     'Neos.Neos:Backend.PublishToLiveWorkspace':
       label: Allowed to publish to the live workspace

Neos.Neos/Configuration/Routes.Backend.yaml

@@ -41,20 +41,6 @@
     '@action':     'createImageVariant'
   httpMethods: ['POST']
 
--
-  name: 'Content Module - Plugin Views'
-  uriPattern: 'content/plugin-views'
-  defaults:
-    '@controller': 'Backend\Content'
-    '@action':     'pluginViews'
-
--
-  name: 'Content Module - Master Plugins'
-  uriPattern: 'content/master-plugins'
-  defaults:
-    '@controller': 'Backend\Content'
-    '@action':     'masterPlugins'
-
 -
   name: 'Schema - NodeType'
   uriPattern: 'schema/node-type'

Neos.Neos/Resources/Private/Translations/en/Main.xlf

@@ -454,18 +454,6 @@
 			<trans-unit id="content.inspector.unappliedChangesDialog.button.success" xml:space="preserve">
 				<source>Apply</source>
 			</trans-unit>
-			<trans-unit id="content.inspector.editors.masterPluginEditor.selectPlugin" xml:space="preserve">
-				<source>Select a Plugin</source>
-			</trans-unit>
-			<trans-unit id="content.inspector.editors.masterPluginEditor.noPluginConfigured" xml:space="preserve">
-				<source>No plugin configured</source>
-			</trans-unit>
-			<trans-unit id="content.inspector.editors.pluginViewsEditor.displayedOnPage" xml:space="preserve">
-				<source>view is displayed on page</source>
-			</trans-unit>
-			<trans-unit id="content.inspector.editors.pluginViewsEditor.displayedOnCurrentPage" xml:space="preserve">
-				<source>view is displayed on current page</source>
-			</trans-unit>
 			<trans-unit id="content.inspector.editors.dateTimeEditor.noDateSet" xml:space="preserve">
 				<source>No date set</source>
 			</trans-unit>