Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove legacy cr functional test artifacts #5036

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 9, 2024

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@nezaniel
Copy link
Member

Do we already want to merge this as long as there are references like "xyz test will be rewritten in..." in here?
I'd like to first merge those new tests before removing old ones. Or are the old ones not being run anyway?

@mhsdesign
Copy link
Member Author

mhsdesign commented May 11, 2024

Yes they are really not, but i put in issues what has to be migrated. Its just super annoying to always come across these in string replacements.

This pr mostly removes the site.xml things ... the real legacy tests ... the Neos ones are still there to be migrated with markAsSkipped.

So this removes just a super small portion that really annoyed me :D

@nezaniel nezaniel self-requested a review May 11, 2024 16:11
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it with fire

@mhsdesign mhsdesign merged commit 7c5784f into neos:9.0 May 11, 2024
12 checks passed
bwaidelich added a commit that referenced this pull request May 25, 2024
- Remove empty `provides` (follow-up to #4700)
- Remove functional test traces (follow-up to #5036)
@bwaidelich
Copy link
Member

FYI: this one broke composer test script => #5095

@mhsdesign mhsdesign deleted the task/remove-legacy-cr-functional-test-restbestandsteile branch May 25, 2024 10:03
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Jul 3, 2024
neos-bot pushed a commit to neos/neos that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants